Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-logs-otlp-proto): Use correct config type in constructor #5058

Merged

Conversation

raphael-theriault-swi
Copy link
Contributor

Which problem is this PR solving?

The OTLPLogExporter constructor doesn't specify the correct config type. This updates it from OTLPExporterConfigBase to OTLPExporterNodeConfigBase.

Fixes #5057

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@raphael-theriault-swi raphael-theriault-swi requested a review from a team as a code owner October 9, 2024 18:03
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (859c0ef) to head (33f17b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5058      +/-   ##
==========================================
+ Coverage   93.26%   93.27%   +0.01%     
==========================================
  Files         317      317              
  Lines        8194     8194              
  Branches     1640     1640              
==========================================
+ Hits         7642     7643       +1     
+ Misses        552      551       -1     
Files with missing lines Coverage Δ
...gs-otlp-proto/src/platform/node/OTLPLogExporter.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Oct 10, 2024
Merged via the queue into open-telemetry:main with commit 039db0b Oct 10, 2024
21 checks passed
Annosha pushed a commit to Annosha/opentelemetry-js that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect constructor typing for http/proto OTLPLogExporter
2 participants