Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style fix: export utility functions directly without container class #345

Closed
draffensperger opened this issue Sep 26, 2019 · 1 comment · Fixed by #391
Closed

Style fix: export utility functions directly without container class #345

draffensperger opened this issue Sep 26, 2019 · 1 comment · Fixed by #391
Assignees
@OlivierAlbertini
Labels
feature-request

Comments

@draffensperger
Copy link
Contributor

JS/TS has the concept of modules as containers for code, so there isn't a need for a wrapper Utils class at there would be in Java.

The opentelemetry-plugin-http has two such Utils classes:

https://github.com/open-telemetry/opentelemetry-js/blob/b1255217a6f491756335fcb0945f4c8f205e0200/packages/opentelemetry-plugin-http/test/utils/Utils.ts

https://github.com/open-telemetry/opentelemetry-js/blob/cee42d8a97b9d24ebd76be5a63ff9673a4b2289f/packages/opentelemetry-plugin-http/src/utils.ts

This issue tracks refactoring those so that they just export the utility functions directly.
@draffensperger
Copy link
Contributor Author

See mention of this in https://github.com/open-telemetry/opentelemetry-js/pull/335/files#r328119196

@draffensperger draffensperger mentioned this issue Sep 26, 2019
Merged
@OlivierAlbertini OlivierAlbertini self-assigned this Sep 26, 2019
@mayurkale22 mayurkale22 mentioned this issue Oct 1, 2019
Merged
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Oct 2, 2019
@OlivierAlbertini
refactor(plugin-http): remove utility class container
1fede59 
closes open-telemetry#345

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini mentioned this issue Oct 2, 2019
Merged
mayurkale22 pushed a commit that referenced this issue Oct 2, 2019
@OlivierAlbertini @mayurkale22
refactor(plugin-http): remove utility class container (#391)
9d9691f 
closes #345

Signed-off-by: Olivier Albertini <[email protected]>
@dyladan dyladan mentioned this issue Dec 17, 2019
Merged
lukaswelinder pushed a commit to agile-pm/opentelemetry-js that referenced this issue Jul 24, 2020
@fapspirit @yurishkuro
Avoid mutation of user's tags (open-telemetry#348)
a12692c 
Clone `options.tags` before assignment due to unnecessary mutations
inside `Tracer` (open-telemetry#345)

Signed-off-by: Fedorov Anton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierAlbertini OlivierAlbertini

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(plugin-http): remove utility class container VilledeMontreal/opentelemetry-js
2 participants
@draffensperger @OlivierAlbertini