Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set status with StatusCode (Unset, Ok, Error) #1634

Closed
dyladan opened this issue Oct 28, 2020 · 2 comments · Fixed by #1644
Closed

Set status with StatusCode (Unset, Ok, Error) #1634

dyladan opened this issue Oct 28, 2020 · 2 comments · Fixed by #1644
Assignees
@srikanthccv
Labels
feature-request

Comments

@dyladan
Copy link
Member

dyladan commented Oct 28, 2020

Our current status code is gRPC code

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md#set-status

Update compliance matrix after fix
srikanthccv added a commit to srikanthccv/opentelemetry-js that referenced this issue Nov 1, 2020
@srikanthccv
fix: change status codes from grpc status codes
1b24b8b 
closes open-telemetry#1634
@srikanthccv srikanthccv mentioned this issue Nov 1, 2020
Merged
@srikanthccv
Copy link
Member

Hi @dyladan, I am trying to address this in #1644. I would appreciate your review.

@dyladan
Copy link
Member Author

dyladan commented Nov 2, 2020

@lonewolf3739 yes I saw thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: change status codes from grpc status codes srikanthccv/opentelemetry-js
2 participants
@dyladan @srikanthccv