Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ship esm version #1378

Closed
vankop opened this issue Aug 3, 2020 · 5 comments · Fixed by #2112
Closed

ship esm version #1378

vankop opened this issue Aug 3, 2020 · 5 comments · Fixed by #2112
Labels
feature-request

Comments

@vankop
Copy link

vankop commented Aug 3, 2020

Is your feature request related to a problem? Please describe.

ESM is more "friendly" for web.
Pros:

  1. consumable for esm-first bundlers by default
  2. easy to tree-shaking. Probably all tree-shaking should work
  3. probably decrease transfer code size when one file (e.g. esm.js) shipped. (more compile-time optimization: e.g. mangling, compression)

Describe the solution you'd like

Setup rollup bundling for packages. I could help here 🤓

Describe alternatives you've considered

webpack@5 as a bundler is not ready for this task yet..

Additional context

Side note: all code written mostly in object-oriented style, technically, functional style code easier to compress (you don't need to track this context)
@dyladan
Copy link
Member

dyladan commented Aug 3, 2020

I could help here 🤓

Would you like to be assigned this issue?

@vankop
Copy link
Author

vankop commented Aug 3, 2020

I could help here 🤓

Would you like to be assigned this issue?

Yep

@xirzec
Copy link

xirzec commented Sep 29, 2020

This looks like the same request as #1253

@ramya-rao-a
Copy link

@vankop Any updates since this issue was assigned to you?

@vankop
Copy link
Author

vankop commented Dec 24, 2020

sorry, did not finished it in august and did not look on it later..

@vankop vankop removed their assignment Dec 24, 2020
@t2t2 t2t2 mentioned this issue Mar 24, 2021
Merged
@t2t2 t2t2 mentioned this issue Apr 15, 2021
Merged
@t2t2 t2t2 mentioned this issue Apr 28, 2021
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@passcod @dyladan @blumamir
docs: Remove duplication in auto-instrumentations-node readme (open-t…
799b10b 
…elemetry#1378)

* Remove duplication in readme

* Just the deduplication, not the sort

* Remove http duplicate

* Sort list

---------

Co-authored-by: Daniel Dyla <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ESM builds for packages used in browser t2t2/opentelemetry-js
4 participants
@xirzec @dyladan @vankop @ramya-rao-a