bug(exporter-collector): error while sending spans

[vmarchaud]

When trying to use the latest exporter-collector i get those logs:

exportTraceServiceRequest {
resourceSpans: [ { resource: [Object], instrumentationLibrarySpans: [Array] } ]
}
2 UNKNOWN: address X.Y.Z.dev: missing port in address

My guess would be that they come from there but i can't figure out why its happening.
Note: X.Y.Z.dev are the host of which my service are exposed and it's not configured at the application level.

Maybe @obecny have an idea since you worked on it ?

[dyladan]

@mayurkale22 didn't you do something to do with the url in collector exporter defaults recently?

/cc @obecny because he wrote the exporter

[vmarchaud]

I have defined a specific URL relative to my setup so i'm not sure that would be that. I can still push traces and i see them where i export them but i'm missing some spans (mostly mongodb ones)

[dyladan]

This is happening on all exports or only some exports? Some or all hosts?

[obecny]

Hard to say anything without debugging your case, as recently the collector has been refactored. Try to debug yrself - there are 2 versions for node nad for browser

[vmarchaud]

The log happens on all services that have OT JS running, the collector is a single instance, i use the version on the repo contrib (master)

[dyladan]

I would start by checking the value of this var. https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-exporter-collector/src/platform/node/CollectorExporter.ts#L66

[mayurkale22]

const exporter = new CollectorExporter({
  serviceName: 'basic-service',
  url: 'X.Y.Z.dev:55678',
});

Assuming you're trying in node.js and you have something like above code to initiate the CollectorExporter, right?

[vmarchaud]

@mayurkale22 Yeah, however i've sent the serviceName to a another string than the host present in the error log.

Edit: the host i've given above is the hostname of the service itself (used to route traffic to it) not the collector one.

[mayurkale22]

Could you pls try running https://github.com/open-telemetry/opentelemetry-js/tree/master/examples/collector-exporter-node example w/ direct collector address and w/ hostname of the service?

[vmarchaud]

Sorry it was a problem with an exporter of the collector (elastic in this case: open-telemetry/opentelemetry-collector-contrib#240).
However i'm wondering if we should need to add inside the log that the error comes from the collector and not the sdk itself, WDYT ?