Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(core): crash in batchspanprocessor with latest version #1052

Closed
vmarchaud opened this issue May 13, 2020 · 5 comments
Closed

bug(core): crash in batchspanprocessor with latest version #1052

vmarchaud opened this issue May 13, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@vmarchaud
Copy link
Member

/home/node/node_modules/@opentelemetry/plugin-ioredis/build/src/utils.js:56
            throw error;
            ^
TypeError: span.toReadableSpan is not a function
    at BatchSpanProcessor.onEnd (/home/node/node_modules/@opentelemetry/tracing/build/src/export/BatchSpanProcessor.js:49:32)
    at MultiSpanProcessor.onEnd (/home/node/node_modules/@opentelemetry/node/node_modules/@opentelemetry/tracing/build/src/MultiSpanProcessor.js:38:27)
    at Span.end (/home/node/node_modules/@opentelemetry/node/node_modules/@opentelemetry/tracing/build/src/Span.js:123:29)
    at endSpan (/home/node/node_modules/@opentelemetry/plugin-ioredis/build/src/utils.js:31:10)
    at Redis.connect (/home/node/node_modules/@opentelemetry/plugin-ioredis/build/src/utils.js:51:13)
    at new Redis (/home/node/node_modules/ioredis/built/redis/index.js:140:14)
    at redisFactory (/home/node/src/lib/redis.js:14:17)
    at /home/node/src/lib/cache_factory.js:39:16
    at Object.<anonymous> (/home/node/src/services/capture2/index.js:63:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at Module.Hook._require.Module.require (/home/node/node_modules/require-in-the-middle/index.js:80:39)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/home/node/src/controllers/html.js:5:40)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
@vmarchaud vmarchaud changed the title bug(ioredis): crash with latest sdk versions bug(core): crash in batchspanprocessor with latest version May 13, 2020
@vmarchaud vmarchaud transferred this issue from open-telemetry/opentelemetry-js-contrib May 13, 2020
@vmarchaud vmarchaud added the bug Something isn't working label May 13, 2020
@vmarchaud
Copy link
Member Author

The error is thrown inside the ioredis plugin because its rethrowing errors inside a try/catch

@dyladan
Copy link
Member

dyladan commented May 13, 2020

@vmarchaud if you're taking care of this assign yourself, if not I'll take a look

@vmarchaud
Copy link
Member Author

@dyladan don't have time today, feel free to look into it

@dyladan dyladan self-assigned this May 13, 2020
@dyladan
Copy link
Member

dyladan commented May 14, 2020

@vmarchaud I suspect you are using an older version of some module or exporter? toReadableSpan has been completely purged from the repository. It still exists in one place in contrib (a test), but that module depends on an older version of the SDK. There is an open contrib PR to bring them to the latest sdk version.

@vmarchaud
Copy link
Member Author

@dyladan You might be correct, i miss the update of the tracing package, i will retry and re-open i'm able to replicate

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants