Skip to content

Commit

Permalink
Move SpanOptions to separate module (#95)
Browse files Browse the repository at this point in the history
  • Loading branch information
mayurkale22 authored Jul 11, 2019
1 parent 5019fe2 commit e0d4c61
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 21 deletions.
1 change: 1 addition & 0 deletions packages/opentelemetry-types/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export * from './trace/Event';
export * from './trace/link';
export * from './trace/Sampler';
export * from './trace/span';
export * from './trace/SpanOptions';
export * from './trace/span_context';
export * from './trace/span_kind';
export * from './trace/status';
Expand Down
43 changes: 43 additions & 0 deletions packages/opentelemetry-types/src/trace/SpanOptions.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/**
* Copyright 2019, OpenTelemetry Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { Span } from './span';
import { Attributes } from './attributes';
import { SpanKind } from './span_kind';
import { SpanContext } from './span_context';

/**
* Options needed for span creation
*/
export interface SpanOptions {
/** The SpanKind of a span */
kind?: SpanKind;

/** A spans attributes */
attributes?: Attributes;

/** Indicates that events are being recorded for a span */
isRecordingEvents?: boolean;

/**
* A parent SpanContext (or Span, for convenience) that the newly-started
* span will be the child of.
*/
parent?: Span | SpanContext;

/** A manually specified start time for the created Span object. */
startTime?: number;
}
22 changes: 1 addition & 21 deletions packages/opentelemetry-types/src/trace/tracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,7 @@
*/

import { Span } from './span';
import { Attributes } from './attributes';
import { SpanKind } from './span_kind';
import { SpanContext } from './span_context';

/**
* Options needed for span creation
*
* @todo: Move into module of its own
*/
export interface SpanOptions {
/** The SpanKind of a span */
kind?: SpanKind;
/** A spans attributes */
attributes?: Attributes;
/** Indicates that events are being recorded for a span */
isRecordingEvents?: boolean;
/** The parent span */
parent?: Span | SpanContext;
/** The start timestamp of a span */
startTime?: number;
}
import { SpanOptions } from './SpanOptions';

/**
* Tracer provides an interface for creating {@link Span}s and propagating
Expand Down

0 comments on commit e0d4c61

Please sign in to comment.