fix(core): stop rounding to nearest int in hrTimeTo*seconds() functions

open-telemetry · Jul 21, 2023 · be3bf19 · be3bf19
1 parent 87f21ef
commit be3bf19
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
 
 ### :bug: (Bug Fix)
 
+* fix(core): stop rounding to nearest int in hrTimeTo*seconds() functions [#4014](https://github.com/open-telemetry/opentelemetry-js/pull/4014/) @aabmass
+
 ### :books: (Refine Doc)
 
 ### :house: (Internal)

diff --git a/packages/opentelemetry-core/src/common/time.ts b/packages/opentelemetry-core/src/common/time.ts
@@ -129,15 +129,15 @@ export function hrTimeToNanoseconds(time: api.HrTime): number {
  * @param time
  */
 export function hrTimeToMilliseconds(time: api.HrTime): number {
-  return Math.round(time[0] * 1e3 + time[1] / 1e6);
+  return time[0] * 1e3 + time[1] / 1e6;
 }
 
 /**
  * Convert hrTime to microseconds.
  * @param time
  */
 export function hrTimeToMicroseconds(time: api.HrTime): number {
-  return Math.round(time[0] * 1e6 + time[1] / 1e3);
+  return time[0] * 1e6 + time[1] / 1e3;
 }
 
 /**

diff --git a/packages/opentelemetry-shim-opentracing/test/Shim.test.ts b/packages/opentelemetry-shim-opentracing/test/Shim.test.ts
@@ -261,7 +261,7 @@ describe('OpenTracing Shim', () => {
         assert.strictEqual(otSpan.links.length, 1);
         assert.deepStrictEqual(
           hrTimeToMilliseconds(otSpan.startTime),
-          Math.round(now + adjustment + performance.timeOrigin)
+          now + adjustment + performance.timeOrigin
         );
         assert.deepStrictEqual(otSpan.attributes, opentracingOptions.tags);
       });
@@ -495,7 +495,7 @@ describe('OpenTracing Shim', () => {
       const adjustment = otSpan['_performanceOffset'];
       assert.deepStrictEqual(
         hrTimeToMilliseconds(otSpan.endTime),
-        Math.round(now + adjustment + performance.timeOrigin)
+        now + adjustment + performance.timeOrigin
       );
     });