Skip to content

Commit

Permalink
chore: address PR comments
Browse files Browse the repository at this point in the history
vmarchaud committed Jan 11, 2020
1 parent 5a12022 commit 78a933b
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -89,7 +89,7 @@ export class PluginLoader {
);
if (requiredModulesToHook.length > 0) {
this.logger.warn(
`Some modules (${requiredModulesToHook}) were already required when their respective plugin were loaded, some plugins might not work. Make sure the SDK is setup before you require in other modules.`
`Some modules (${requiredModulesToHook.join(', ')}) were already required when their respective plugin was loaded, some plugins might not work. Make sure the SDK is setup before you require in other modules.`
);
}

Original file line number Diff line number Diff line change
@@ -238,7 +238,7 @@ describe('PluginLoader', () => {
},
};
require('already-require-module');
const pluginLoader = new PluginLoader(tracer, verifyWarnLogger);
const pluginLoader = new PluginLoader(registry, verifyWarnLogger);
pluginLoader.load(alreadyRequiredPlugins);
pluginLoader.unload();
});

0 comments on commit 78a933b

Please sign in to comment.