Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove forcing RUN_MSSQL_TESTS to be true in tests #965

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Apr 9, 2022

Which problem is this PR solving?

Someone(khm...) has left a typo into the tests forcing MSSQL test always to be run.

@rauno56 rauno56 requested a review from a team April 9, 2022 10:02
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #965 (f17589c) into main (670797a) will decrease coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   95.91%   95.44%   -0.47%     
==========================================
  Files          13       15       +2     
  Lines         856      966     +110     
  Branches      178      197      +19     
==========================================
+ Hits          821      922     +101     
- Misses         35       44       +9     
Impacted Files Coverage Δ
plugins/node/instrumentation-tedious/src/utils.ts 88.23% <0.00%> (ø)
...ode/instrumentation-tedious/src/instrumentation.ts 92.47% <0.00%> (ø)

@rauno56 rauno56 merged commit bcbdeb7 into open-telemetry:main Apr 11, 2022
@rauno56 rauno56 deleted the test/fix-mssql-force-run branch April 11, 2022 07:55
@dyladan dyladan mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants