feat: support API and SDK 1.0 #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned blumamir, legendecas, naseemkullah, NathanielRN, obecny, rauno56 and willarmiros
github-actions
bot
requested review from
blumamir,
legendecas,
naseemkullah,
NathanielRN,
obecny,
rauno56 and
willarmiros
willarmiros
approved these changes
Oct 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 96.86% 97.75% +0.89%
==========================================
Files 9 7 -2
Lines 638 357 -281
Branches 126 56 -70
==========================================
- Hits 618 349 -269
+ Misses 20 8 -12
|
vmarchaud
approved these changes
Oct 18, 2021
Flarna
approved these changes
Oct 18, 2021
legendecas
approved these changes
Oct 19, 2021
legendecas
reviewed
Oct 19, 2021
| @@ -6,6 +6,8 @@ The OpenTelemetry Resource is an immutable representation of the entity producin | |||
|
|
|||
| [This document][resource-semantic_conventions] defines standard attributes for resources. | |||
|
|
|||
| Supports OpenTelemetry JS SDK 1.0 | |||
There was a problem hiding this comment.
This seems to be different from others. Is it intentional?
obecny
approved these changes
Oct 19, 2021
weyert
approved these changes
Oct 19, 2021
rauno56
approved these changes
Oct 20, 2021
blumamir
approved these changes
Oct 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #695 dependencies were updated to use the SDK 1.0.
Because the conventional commits specifier used was
chore, the release automation did not bump the minor version of packages that were updated. This Adds a simple statement to the readme of each package and uses thefeatspecifier to ensure the minor version will be incremented./cc @Flarna