-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update aws-lambda-instrumentation to SDK v0.25.0 #660
Conversation
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 96.82% 96.44% -0.38%
==========================================
Files 9 14 +5
Lines 630 1210 +580
Branches 124 171 +47
==========================================
+ Hits 610 1167 +557
- Misses 20 43 +23
|
Converting to draft since this doesn't fix the bug (yet). Just wanted to test it with GH Actions, but am reproducing locally now. |
Now that #661 is merged this is ready for review 👍 |
@@ -23,8 +23,8 @@ import { AwsLambdaInstrumentation } from '../../src'; | |||
import { | |||
BatchSpanProcessor, | |||
InMemorySpanExporter, | |||
} from '@opentelemetry/tracing'; | |||
import { NodeTracerProvider } from '@opentelemetry/node'; | |||
} from '@opentelemetry/sdk-trace-base'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency is missing in package.json dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in devDependencies
. Basically, if the tests passes, then we are good as the dependencies are good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not, but it has been added. It was a transitive dependency of something else which is why the tests were passing but it is good practice to declare all of your dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, I'm blind. Thanks for sharing your perspective.
Which problem is this PR solving?
Short description of the changes
0.25.0
, and fixing associated breaking changes.