-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade @types/pino to be compatible with latest sonic-stream types #592
Conversation
…st sonic-stream types
Does this still work for users using an older version of @types/pino? A while ago we had a discussion if we should pin the version here or not. Or even use |
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 179 179
Lines 10976 10976
Branches 1088 1088
=======================================
Hits 10404 10404
Misses 572 572 |
IIUC, types maintained in DefinitelyTyped versioned with the same I'm not sure which condition you are referring to. If you mean users that declared their own @types/pino dependencies in their package, as long as the user-defined version range is compatible with the version defined in @opentelemetry/instrumentation-pino, it should be fine. |
IIUC, the instrumentation package should set a version range of pino that it supports (like say, declare a set of version range in peer dependencies). A |
@types packages follow major.minor of their original. They may add/remove/rework definitions during this resulting in breakage like here. So in short @types packages don't follow semver (and this is documented at DefinitelyTyped).
I mean the version selected by the end user. |
Merging this since it is fixing the build which breaks in every PR |
Which problem is this PR solving?
Short description of the changes