-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detectors): add alibaba cloud detector #590
feat(detectors): add alibaba cloud detector #590
Conversation
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 94.94% 94.90% -0.05%
==========================================
Files 195 195
Lines 11637 11617 -20
Branches 1115 1091 -24
==========================================
- Hits 11049 11025 -24
- Misses 588 592 +4 |
detectors/node/opentelemetry-resource-detector-alibaba-cloud/LICENSE
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json
Outdated
Show resolved
Hide resolved
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Show resolved
Hide resolved
...opentelemetry-resource-detector-alibaba-cloud/test/detectors/AlibabaCloudEcsDetector.test.ts
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json
Outdated
Show resolved
Hide resolved
2bf3ccd
to
54ef228
Compare
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
…rc/detectors/AlibabaCloudEcsDetector.ts Co-authored-by: Gerhard Stöbich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just few nitpicks and one question
detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json
Outdated
Show resolved
Hide resolved
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
.../node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
Outdated
Show resolved
Hide resolved
} from '@opentelemetry/test-utils'; | ||
|
||
const ALIYUN_HOST = | ||
'http://' + alibabaCloudEcsDetector.ALIBABA_CLOUD_IDMS_ENDPOINT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really http
and not https
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is http
. The address is not available in the public network. The IP range is reserved for carrier usage.
Can you please add yourself as owner to |
@dyladan updated :) |
Which problem is this PR solving?
Short description of the changes