Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: permanently delete opentelemetry-browser-extension-autoinjection #2661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chancancode
Copy link

@chancancode chancancode commented Jan 17, 2025

This package was archived in #2285, the code no logner builds and contains legacy/deprecated patterns that will stop working with SDK 2.0, which we have no intention to fix.

Added a link to the last snapshot of the code for those who are looking to reference the archived code.

Uses this GitHub-specific markdown annotation.


I found this while working on #2645, specifically this usage:

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/archive/opentelemetry-browser-extension-autoinjection/src/instrumentation/WebInstrumentation.ts#L45-L81

Since the caller passes in an already-instantiated provider, this cannot be easily fixed. In any case, we clearly have no intention to release a new version of this package so it's a bit moot.

The intention was to freeze the code, but it's annoying that it comes up in the search for these type of migrations/refactor efforts. Looking at the commit history, it was already updated a handful of times by similar efforts despite the stated intention to keep the code frozen.

In #2285, @blumamir said:

I support removing the code (which one can also find in git by checking out to an early commit) and leaving just a note in the README to communicate the status so that it won't go away for some reasonable time.

The code pops up in IDE searches and may still promote old practices which I don't see any good reason to keep anymore.

...and @pichlermarc said...

Let's merge this PR and then we can still follow up on removing the code.

I agree with @blumamir so here I am finishing the job 😀

This package was archived in open-telemetry#2285, the code no logner builds and
contains legacy/deprecated patterns that will stop working with SDK
2.0, which we have no intention to fix.

Added a link to the last snapshot of the code for those who are
looking to reference the archived code.
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (e57f3e4) to head (4c62420).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
+ Coverage   90.79%   90.80%   +0.01%     
==========================================
  Files         169      169              
  Lines        8061     8061              
  Branches     1646     1646              
==========================================
+ Hits         7319     7320       +1     
+ Misses        742      741       -1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants