Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test-utils): Migrate away from deprecated addSpanProcessor #2660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chancancode
Copy link

This migrates from the deprecated addSpanProcessor method to the constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates the runtime code in the test-utils package and should be included in the package's CHANGELOG.

Ref #2645 (cc @pichlermarc)

This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates the runtime code in the test-utils package and
should be included in the package's CHANGELOG.

Ref open-telemetry#2645
@chancancode
Copy link
Author

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.github/component-label-map.yml#L5

I suppose these rules are to ping maintainers to look at any changes to the shared test utils, which is fair enough (though this is really minor).

However, for the purpose of lerna-changelog, the pkg labels are definitely wrong. That should be fixed before merging.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (e57f3e4) to head (31dd654).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2660   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         169      169           
  Lines        8061     8061           
  Branches     1646     1646           
=======================================
  Hits         7319     7319           
  Misses        742      742           

@pichlermarc pichlermarc changed the title fix(test-utils): Migrate away from deprecated addSpanProcessor refactor(test-utils): Migrate away from deprecated addSpanProcessor Jan 17, 2025
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks - I've changed the title to be refactor this way it won't show up as a bugfix in the changelog.

@pichlermarc
Copy link
Member

The package lables won't affect the changelog - the entry generated will only be for contrib-test-utils :)
We use them to determine which tests need to be run and to give an overview of which packages in the repo are affected by the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment