Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws): replace deprecated substr with substring #2551

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 26, 2024

Which problem is this PR solving?

Short description of the changes

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (d5215f3) to head (6fbb3b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2551      +/-   ##
==========================================
- Coverage   90.80%   90.75%   -0.05%     
==========================================
  Files         169      169              
  Lines        8018     8018              
  Branches     1632     1632              
==========================================
- Hits         7281     7277       -4     
- Misses        737      741       +4     
Files with missing lines Coverage Δ
...-instrumentation-aws-lambda/src/instrumentation.ts 93.60% <100.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 94.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@pichlermarc pichlermarc merged commit 468222b into open-telemetry:main Nov 26, 2024
20 checks passed
@trivikr trivikr deleted the aws-substr branch November 26, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants