Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples/redis): use crypto.randomBytes to generate uuid #2546

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 22, 2024

Which problem is this PR solving?

Short description of the changes

  • uses crypto.randomBytes to generate uuid as recommended by CodeQL

@trivikr trivikr marked this pull request as ready for review November 22, 2024 05:30
@trivikr trivikr requested a review from a team as a code owner November 22, 2024 05:30
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (468222b) to head (f34bcc6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8018           
  Branches     1632     1632           
=======================================
  Hits         7277     7277           
  Misses        741      741           

@trivikr
Copy link
Contributor Author

trivikr commented Nov 25, 2024

cc @pichlermarc who approved workflow for related change.

@trentm trentm changed the title chore: use crypto.randomBytes to generate uuid chore(examples/redis): use crypto.randomBytes to generate uuid Nov 25, 2024
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

@pichlermarc pichlermarc merged commit 2784357 into open-telemetry:main Nov 26, 2024
10 checks passed
@trivikr trivikr deleted the example-redix-codeql branch November 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants