Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update deps matching "@opentelemetry/" #2408

Merged
merged 6 commits into from
Aug 30, 2024
Merged

chore(deps): update deps matching "@opentelemetry/" #2408

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b9b495
chore(deps): update deps matching "@opentelemetry/"
pichlermarc Aug 28, 2024
f8cb2e7
fixup! chore(deps): update deps matching "@opentelemetry/"
pichlermarc Aug 28, 2024
b408671
fixup! chore(deps): update deps matching "@opentelemetry/"
pichlermarc Aug 28, 2024
594b939
test(express): fix up tests to match fixed http instrumentation, use …
pichlermarc Aug 29, 2024
3c598bb
fixup! test(express): fix up tests to match fixed http instrumentatio…
pichlermarc Aug 29, 2024
bd2a449
test(instrumentation-koa): assert for correct SpanKind, account for h…
pichlermarc Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-bunyan/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class BunyanInstrumentation extends InstrumentationBase<BunyanInstrumenta
}

override setConfig(config: BunyanInstrumentationConfig = {}) {
this._config = { ...DEFAULT_CONFIG, ...config };
Copy link
Member Author

@pichlermarc pichlermarc Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewer note: this did override the enabled config and actually disabled the instrumentation, this went unnoticed until the change from open-telemetry/opentelemetry-js@0ee398d which now uses this method instead of setting it directly.

super.setConfig({ ...DEFAULT_CONFIG, ...config });
}

private _getPatchedEmit() {
Expand Down
1 change: 0 additions & 1 deletion plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ loggerProvider.addLogRecordProcessor(new SimpleLogRecordProcessor(memExporter));
logs.setGlobalLoggerProvider(loggerProvider);

const instrumentation = new BunyanInstrumentation();
instrumentation.enable();
const Logger = require('bunyan');

describe('BunyanInstrumentation', () => {
Expand Down
Loading