fix(auto-instrumentations-node): shutdown the SDK when the process exits normally #2394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2383
Short description of the changes
Adds a one-shot
beforeExit
hook to callNodeSDK.shutdown()
. In the event of SIGTERM and the process gracefully exiting, shutdown may be called twice. I believe the additional calls toshutdown()
should no-op so that is not a concern but may make for spammy logs.I updated the tests to capture the expected behavior