chore(instrumentation-bunyan): use strings exported for attributes #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update strings exportes for Resource Attributes Signed-off-by: maryliag <[email protected]>
59 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
==========================================
- Coverage 90.97% 90.37% -0.61%
==========================================
Files 146 147 +1
Lines 7492 7500 +8
Branches 1502 1569 +67
==========================================
- Hits 6816 6778 -38
- Misses 676 722 +46 |
trentm
approved these changes
May 10, 2024
trentm
reviewed
May 13, 2024
Comment on lines
121
to
124
| ## Semantic Conventions | ||
|
|
||
| This package uses `@opentelemetry/semantic-conventions` version `1.22+`, which implements Semantic Convention [Version 1.7.0](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.7.0/semantic_conventions/README.md) | ||
|
|
There was a problem hiding this comment.
I kinda think this should be dropped. The only use a semconv in this package is in the tests to use the SERVICE_NAME constant. The dep is a dev-dep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
On package `opentelemetry-instrumentation-bunyan:
@opentelemetry/semantic-conventions^1.23.0