-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Azure Functions instrumentation #2177
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
reviewed
May 7, 2024
plugins/node/opentelemetry-instrumentation-azure-functions/README.md
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
May 7, 2024
plugins/node/opentelemetry-instrumentation-azure-functions/README.md
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
May 10, 2024
plugins/node/opentelemetry-instrumentation-azure-functions/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
May 10, 2024
plugins/node/opentelemetry-instrumentation-azure-functions/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
trentm
reviewed
May 14, 2024
plugins/node/opentelemetry-instrumentation-azure-functions/.eslintignore
Outdated
Show resolved
Hide resolved
now that azure changes have rolled out. and add a few little comments
hectorhdzg
reviewed
May 17, 2024
hectorhdzg
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closing related to #2259 |
where can we follow progress about this now that is closed? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The Azure Functions team plans to announce preview support soon for Open Telemetry across several languages (see this GitHub issue for full details). I work specifically on the Node.js experience, including the
@azure/functions
npm package here. A lot of the implementation for OTel was done in our shared host component which is written in .NET (PR here).Fixes Azure/azure-functions-nodejs-library#245
Short description of the changes
Added new npm package that can do the following for Azure Functions users:
Added my coworker @castrodd and manager @AnatoliB as additional owners.