Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Azure Functions instrumentation #2177

Closed
wants to merge 12 commits into from

Conversation

ejizba
Copy link

@ejizba ejizba commented May 4, 2024

Which problem is this PR solving?

The Azure Functions team plans to announce preview support soon for Open Telemetry across several languages (see this GitHub issue for full details). I work specifically on the Node.js experience, including the @azure/functions npm package here. A lot of the implementation for OTel was done in our shared host component which is written in .NET (PR here).

Fixes Azure/azure-functions-nodejs-library#245

Short description of the changes

Added new npm package that can do the following for Azure Functions users:

  1. Correlate the traces generated from the user's node.js code to the trace context provided by our shared host component
  2. Send logs directly from Node.js instead of our shared host component (this results in better correlation, more flexibility for the user, etc.)

Added my coworker @castrodd and manager @AnatoliB as additional owners.

@ejizba ejizba requested a review from a team May 4, 2024 00:50
Copy link

linux-foundation-easycla bot commented May 4, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

now that azure changes have rolled out.

and add a few little comments
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejizba
Copy link
Author

ejizba commented Jun 19, 2024

Closing related to #2259

@ejizba ejizba closed this Jun 19, 2024
@gunzip
Copy link

gunzip commented Jun 19, 2024

where can we follow progress about this now that is closed? thanks!

@ejizba
Copy link
Author

ejizba commented Jun 19, 2024

Azure/azure-functions-nodejs-library#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support open telemetry
5 participants