Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instr-amqpllib): use semconv strings in test files #2113

Merged

Conversation

david-luna
Copy link
Contributor

Leftover from #2086

Test files were not using the exported strings. Kudos to @trentm for spotting it

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #2113 (7348b3a) into main (dfb2dff) will decrease coverage by 0.63%.
Report is 63 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
- Coverage   90.97%   90.35%   -0.63%     
==========================================
  Files         146      147       +1     
  Lines        7492     7679     +187     
  Branches     1502     1575      +73     
==========================================
+ Hits         6816     6938     +122     
- Misses        676      741      +65     

see 9 files with indirect coverage changes

@JamieDanielson JamieDanielson merged commit a5bee9f into open-telemetry:main Apr 23, 2024
17 checks passed
@david-luna david-luna deleted the dluna/amqplib-semconv-strings-2 branch June 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants