Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(host-metrics): macOS bundling fix #2071
fix(host-metrics): macOS bundling fix #2071
Changes from 32 commits
2c6d8cf
60e0933
65aabe7
ae578fc
ce92ffe
e818ba5
2484ef6
1106e97
8f65520
08506a4
63cc39d
03e2237
9cbe462
a2aaa4b
744ea1d
cc8aafe
d1c1fca
a3b898f
a8196e4
304dc98
9f81a2d
769de9e
4fd1f8f
9c30315
83c58a3
2ac772e
343733e
fd50fe5
38b80b1
b642766
5e6370a
deb3257
5922334
06ac5e7
a3f9a61
fc23083
f675811
9c14d64
72ba6f9
4c0c3c9
f0a7187
c0fbc8b
5338456
3df9163
79555fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess with the change suggested by @pichlermarc in
./src/stats/si.ts
this file is no needed. I see the
.d.ts
file fromsysteminformation
exportingnetworkStats
function alreadyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I use
import { networkStats } from 'systeminformation';
, it still tries to import the underlying cpu.js file, thus throwing an error on macOS. :( By targeting the file directly it won't.The systeminformation/lib/cpu.js file tries to import
osx-temperature-sensor
for macOS, which you additionally have to install for macOS temperatures as it's not included in the dependencies, however osx-temp-sensor package breaks something else. But the cpu.js file isn't even used for host-metrics, so installing this package besides systeminformation is unecessary