Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add @opentelemetry/api as peerDependencies in @opentelemetry/resource-detector-azure #1979

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

altinokdarici
Copy link
Contributor

Which problem is this PR solving?

Although @opentelemetry/api is in devDependencies, @opentelemetry/api is missing in @opentelemetry/resource-detector-azure's peerDependencies. This cause failures in strict installation layout for some package managers.

Short description of the changes

Add @opentelemetry/api as peerDependencies in @opentelemetry/resource-detector-azure

@altinokdarici altinokdarici requested a review from a team February 29, 2024 19:31
@altinokdarici altinokdarici changed the title Add @opentelemetry/api as peerDependencies in @opentelemetry/resource-detector-azure fix: Add @opentelemetry/api as peerDependencies in @opentelemetry/resource-detector-azure Feb 29, 2024
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #1979 (14fca21) into main (c00f529) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1979   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         146      146           
  Lines        7491     7491           
  Branches     1501     1501           
=======================================
  Hits         6819     6819           
  Misses        672      672           

@pichlermarc pichlermarc merged commit 2e9fce4 into open-telemetry:main Mar 1, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants