Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add script to update '@opentelemetry/*' deps in this repo #1974

Closed
wants to merge 0 commits into from
Closed

chore: add script to update '@opentelemetry/*' deps in this repo #1974

wants to merge 0 commits into from

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Feb 28, 2024

Refs: #1917

Run npm ci to have a clean install, then run ./scripts/update-otel-deps.js from the top-dir of the repo.
An example run looks like this:

% ./scripts/update-otel-deps.js
Updating deps matching "@opentelemetry/*" in 59 workspace dirs

Gathering info on outdated deps in each workspace:
 - packages/opentelemetry-host-metrics (1 of 59)
 - packages/opentelemetry-id-generator-aws-xray (2 of 59)
 - packages/opentelemetry-propagation-utils (3 of 59)
 - packages/opentelemetry-redis-common (4 of 59)
 - packages/opentelemetry-sql-common (5 of 59)
 - packages/opentelemetry-test-utils (6 of 59)
 - plugins/node/instrumentation-amqplib (7 of 59)
 - plugins/node/instrumentation-cucumber (8 of 59)
 - plugins/node/instrumentation-dataloader (9 of 59)
 - plugins/node/instrumentation-fs (10 of 59)
 - plugins/node/instrumentation-lru-memoizer (11 of 59)
 - plugins/node/instrumentation-mongoose (12 of 59)
 - plugins/node/instrumentation-perf-hooks (13 of 59)
 - plugins/node/instrumentation-socket.io (14 of 59)
 - plugins/node/instrumentation-tedious (15 of 59)
 - plugins/node/opentelemetry-instrumentation-aws-lambda (16 of 59)
 - plugins/node/opentelemetry-instrumentation-aws-sdk (17 of 59)
 - plugins/node/opentelemetry-instrumentation-bunyan (18 of 59)
 - plugins/node/opentelemetry-instrumentation-cassandra (19 of 59)
 - plugins/node/opentelemetry-instrumentation-connect (20 of 59)
 - plugins/node/opentelemetry-instrumentation-dns (21 of 59)
 - plugins/node/opentelemetry-instrumentation-express (22 of 59)
 - plugins/node/opentelemetry-instrumentation-fastify (23 of 59)
 - plugins/node/opentelemetry-instrumentation-generic-pool (24 of 59)
 - plugins/node/opentelemetry-instrumentation-graphql (25 of 59)
 - plugins/node/opentelemetry-instrumentation-hapi (26 of 59)
 - plugins/node/opentelemetry-instrumentation-ioredis (27 of 59)
 - plugins/node/opentelemetry-instrumentation-knex (28 of 59)
 - plugins/node/opentelemetry-instrumentation-koa (29 of 59)
 - plugins/node/opentelemetry-instrumentation-memcached (30 of 59)
 - plugins/node/opentelemetry-instrumentation-mongodb (31 of 59)
 - plugins/node/opentelemetry-instrumentation-mysql (32 of 59)
 - plugins/node/opentelemetry-instrumentation-mysql2 (33 of 59)
 - plugins/node/opentelemetry-instrumentation-nestjs-core (34 of 59)
 - plugins/node/opentelemetry-instrumentation-net (35 of 59)
 - plugins/node/opentelemetry-instrumentation-pg (36 of 59)
 - plugins/node/opentelemetry-instrumentation-pino (37 of 59)
 - plugins/node/opentelemetry-instrumentation-redis-4 (38 of 59)
 - plugins/node/opentelemetry-instrumentation-redis (39 of 59)
 - plugins/node/opentelemetry-instrumentation-restify (40 of 59)
 - plugins/node/opentelemetry-instrumentation-router (41 of 59)
 - plugins/node/opentelemetry-instrumentation-winston (42 of 59)
 - plugins/web/opentelemetry-instrumentation-document-load (43 of 59)
 - plugins/web/opentelemetry-instrumentation-long-task (44 of 59)
 - plugins/web/opentelemetry-instrumentation-user-interaction (45 of 59)
 - plugins/web/opentelemetry-plugin-react-load (46 of 59)
 - propagators/opentelemetry-propagator-aws-xray (47 of 59)
 - propagators/opentelemetry-propagator-grpc-census-binary (48 of 59)
 - propagators/opentelemetry-propagator-instana (49 of 59)
 - propagators/opentelemetry-propagator-ot-trace (50 of 59)
 - detectors/node/opentelemetry-resource-detector-alibaba-cloud (51 of 59)
 - detectors/node/opentelemetry-resource-detector-aws (52 of 59)
 - detectors/node/opentelemetry-resource-detector-azure (53 of 59)
 - detectors/node/opentelemetry-resource-detector-container (54 of 59)
 - detectors/node/opentelemetry-resource-detector-gcp (55 of 59)
 - detectors/node/opentelemetry-resource-detector-github (56 of 59)
 - detectors/node/opentelemetry-resource-detector-instana (57 of 59)
 - metapackages/auto-instrumentations-node (58 of 59)
 - metapackages/auto-instrumentations-web (59 of 59)

Performing updates (1 `npm install ...`s, 0 `npm update ...`):
 $ cd plugins/node/instrumentation-perf-hooks && npm install @opentelemetry/[email protected]

Sanity check that all matching packages are up-to-date:
 $ npm outdated @opentelemetry/sdk-metrics @opentelemetry/api @opentelemetry/core @opentelemetry/contrib-test-utils @opentelemetry/exporter-jaeger @opentelemetry/instrumentation @opentelemetry/sdk-trace-node @opentelemetry/resources @opentelemetry/sdk-node @opentelemetry/sdk-trace-base @opentelemetry/semantic-conventions @opentelemetry/context-async-hooks @opentelemetry/propagator-aws-xray @opentelemetry/propagation-utils @opentelemetry/api-logs @opentelemetry/sdk-logs @opentelemetry/instrumentation-http @opentelemetry/redis-common @opentelemetry/sql-common @opentelemetry/sdk-trace-web @opentelemetry/context-zone-peer-dep @opentelemetry/instrumentation-xml-http-request @opentelemetry/context-zone @opentelemetry/propagator-b3 @opentelemetry/instrumentation-amqplib @opentelemetry/instrumentation-aws-lambda @opentelemetry/instrumentation-aws-sdk @opentelemetry/instrumentation-bunyan @opentelemetry/instrumentation-cassandra-driver @opentelemetry/instrumentation-connect @opentelemetry/instrumentation-cucumber @opentelemetry/instrumentation-dataloader @opentelemetry/instrumentation-dns @opentelemetry/instrumentation-express @opentelemetry/instrumentation-fs @opentelemetry/instrumentation-fastify @opentelemetry/instrumentation-generic-pool @opentelemetry/instrumentation-graphql @opentelemetry/instrumentation-grpc @opentelemetry/instrumentation-hapi @opentelemetry/instrumentation-ioredis @opentelemetry/instrumentation-knex @opentelemetry/instrumentation-koa @opentelemetry/instrumentation-lru-memoizer @opentelemetry/instrumentation-memcached @opentelemetry/instrumentation-mongodb @opentelemetry/instrumentation-mongoose @opentelemetry/instrumentation-mysql @opentelemetry/instrumentation-mysql2 @opentelemetry/instrumentation-nestjs-core @opentelemetry/instrumentation-net @opentelemetry/instrumentation-pg @opentelemetry/instrumentation-pino @opentelemetry/instrumentation-redis @opentelemetry/instrumentation-redis-4 @opentelemetry/instrumentation-restify @opentelemetry/instrumentation-router @opentelemetry/instrumentation-socket.io @opentelemetry/instrumentation-tedious @opentelemetry/instrumentation-winston @opentelemetry/resource-detector-alibaba-cloud @opentelemetry/resource-detector-aws @opentelemetry/resource-detector-container @opentelemetry/resource-detector-gcp @opentelemetry/instrumentation-document-load @opentelemetry/instrumentation-fetch @opentelemetry/instrumentation-user-interaction

Summary of changes (possible commit message):
--
chore(deps): update deps matching "@opentelemetry/*"

    0.40.0 -> 0.48.0 @opentelemetry/instrumentation (range-bump)
--

And that currently resulted in this change, FWIW:
https://gist.github.com/trentm/663c287c15966a1c894c35032999a5cf

Note that I currently have a separate PR to update that and other deps for instrumentation-perf-tools (#1967). However that other PR can be done whenever.

@trentm trentm requested a review from pichlermarc February 28, 2024 17:58
@trentm trentm self-assigned this Feb 28, 2024
@trentm trentm requested a review from a team February 28, 2024 17:58
trentm
trentm commented Feb 28, 2024
View reviewed changes
scripts/update-otel-deps.js Outdated

const globSync = require('glob').sync; // TODO add top-level devDep on glob
const minimatch = require('minimatch'); // TODO add top-level devDep on minimatch
const semver = require('semver'); // TODO add top-level devDep on semver
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer: This is a little lame. It would be nice to add real top-level devDeps for these. However, I was rushing this PR to get a smaller (no package-lock.json changes) change for you to look at.

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #1974 (85485cb) into main (e11f86e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1974   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         146      146           
  Lines        7491     7491           
  Branches     1501     1501           
=======================================
  Hits         6819     6819           
  Misses        672      672

@pichlermarc pichlermarc mentioned this pull request Feb 29, 2024
Merged
@trentm trentm closed this Mar 5, 2024
@trentm
Copy link
Contributor Author

trentm commented Mar 5, 2024

^^ I've closed this because I stupidly made this PR against the main branch of my fork 🤦 , instead of a feature branch.
I am correcting that, and will open a replacement PR in a moment.

@trentm trentm mentioned this pull request Mar 5, 2024
Merged
@trentm
Copy link
Contributor Author

trentm commented Mar 5, 2024

I am correcting that, and will open a replacement PR in a moment.

#1992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc Awaiting requested review from pichlermarc

Assignees

@trentm trentm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trentm