feat: add esnext target for web instrumentations #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1776 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 143 143
Lines 7299 7299
Branches 1458 1458
=======================================
Hits 6673 6673
Misses 626 626 |
legendecas
approved these changes
Nov 7, 2023
trentm
approved these changes
Nov 7, 2023
pichlermarc
approved these changes
Nov 10, 2023
Merged
jmcdo29
pushed a commit
to jmcdo29/opentelemetry-js-contrib
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Daniel Dyla <[email protected]> Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #1756
Short description of the changes
This adds
esnextbuild target for all web instrumentations. Currently, onlyesmis published, which is incompatible with theesnextcode from core libraries when subclassing (see the linked issue above). This should also reduce bundle size when targeting newer browsers (no polyfills).