fix: fix context loss when cursor are accesed concurrently #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
reviewed
Oct 6, 2023
plugins/node/opentelemetry-instrumentation-mongodb/src/instrumentation.ts
Show resolved
Hide resolved
|
@osherv could you please add your feedback and approval if applies? |
Codecov Report
@@ Coverage Diff @@
## main #1721 +/- ##
==========================================
- Coverage 91.62% 91.49% -0.14%
==========================================
Files 139 139
Lines 7151 7159 +8
Branches 1444 1438 -6
==========================================
- Hits 6552 6550 -2
- Misses 599 609 +10
|
pichlermarc
added
bug
pichlermarc
approved these changes
Oct 12, 2023
plugins/node/opentelemetry-instrumentation-mongodb/src/internal-types.ts
Outdated
Show resolved
Hide resolved
trentm
approved these changes
Oct 12, 2023
…id-luna/opentelemetry-js-contrib into dluna-1688-mongodb-async-context-fix
|
Thanks you both for the review :) @pichlermarc there are some workflows awaiting approval. Are you able to approve them? |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR is solving the problem of
mongodbinstrumentation loosing the context when cursors are accessed concurrently.Short description of the changes
Add a new instrumentation on
ConnectionPoolclass to patch the method that produces the context loss. This class is present from v4 and up so the fix works also for v5Closes #1688