fix(fastify): Use plugin name for middleware span name #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1680 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 129 129
Lines 6402 6402
Branches 1281 1281
=======================================
Hits 5849 5849
Misses 553 553
|
mydea
force-pushed
the
fn/fastify-middleware-name
branch
2 times, most recently
from
5b315e4 to
b1c64a0
Compare
mydea
force-pushed
the
fn/fastify-middleware-name
branch
from
b1c64a0 to
061da0c
Compare
blumamir
approved these changes
Sep 25, 2023
Merged
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 11, 2023
…9223) E2E tests started failing for fastify because of 0.32.3 (https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-fastify/CHANGELOG.md) being released. This includes this change open-telemetry/opentelemetry-js-contrib#1680 (which actually we wrote xD) that changes some span names, which lead to E2E test failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I was getting a bunch
middleware - anonymousspans from my fastify instrumentation.I think it would be more useful to see e.g.
middleware - routerormiddleware - fastify -> @fastify/multipart -> @fastify/helmetthere?