Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin lerna in github workflows #1541

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jun 19, 2023

Which problem is this PR solving?

  • Our GitHub workflows pull the latest version of lerna, but lerna v7 and up do remove lerna bootstrap.

Short description of the changes

  • pins the same version (5.5.2) as in our top-level package.json for now to unblock PRs, I'll open a follow-up issue to upgrade to lerna v7.

See also open-telemetry/opentelemetry-js#3894, #1542

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1541 (f257009) into main (86d38fb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1541   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          14       14           
  Lines         906      906           
  Branches      197      197           
=======================================
  Hits          871      871           
  Misses         35       35           

@pichlermarc pichlermarc marked this pull request as ready for review June 19, 2023 10:25
@pichlermarc pichlermarc requested a review from a team June 19, 2023 10:25
@legendecas legendecas merged commit 476f3ce into open-telemetry:main Jun 19, 2023
@pichlermarc pichlermarc deleted the chore/pin-lerna branch June 19, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants