Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-sdk): bump aws-sdk version to align with previous releases #1302

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

blumamir
Copy link
Member

This is another attempt to fix #1153
I previously fixed it in #1247, but I forgot to update .release-please-manifest.json, so the fix had no effect.
Hopefully, this one will work

@blumamir blumamir requested a review from a team November 24, 2022 16:58
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #1302 (f693f70) into main (28ad01e) will increase coverage by 0.54%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
+ Coverage   96.08%   96.62%   +0.54%     
==========================================
  Files          14       25      +11     
  Lines         893     1454     +561     
  Branches      191      309     +118     
==========================================
+ Hits          858     1405     +547     
- Misses         35       49      +14     
Impacted Files Coverage Δ
...entation-aws-sdk/src/services/MessageAttributes.ts 91.89% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.45% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.21% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 93.75% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
... and 1 more

@Flarna
Copy link
Member

Flarna commented Nov 25, 2022

not sure here but isn't it needed to use fix or feat commit type to ensure that release please actually creates a new release?

@blumamir
Copy link
Member Author

not sure here but isn't it needed to use fix or feat commit type to ensure that release please actually creates a new release?

🤔good point, I don't really know. @dyladan - can you help?

@blumamir
Copy link
Member Author

not sure here but isn't it needed to use fix or feat commit type to ensure that release please actually creates a new release?

Anyway, this change is not urgent, so it can be merged and just join the next release when it happens.
Since it's not really a fix or a feature, I think it does not deserve a bullet in the CHANGELOG.

@blumamir blumamir merged commit cd9984a into open-telemetry:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/instrumentation-aws-sdk has random version number that throws off Snyk
5 participants