feat: add socket.io instrumentation #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
==========================================
+ Coverage 96.08% 96.20% +0.12%
==========================================
Files 14 15 +1
Lines 893 949 +56
Branches 191 195 +4
==========================================
+ Hits 858 913 +55
- Misses 35 36 +1
|
rauno56
reviewed
Nov 15, 2022
There was a problem hiding this comment.
Could we narrow down the versions we TAV-test to contain the CI time a bit?
Most popular versions currently:
┌─────────┬─────────┬──────────────┬─────────────────┬───────────┬──────────┐
│ (index) │ version │ time │ tags │ downloads │ ratio(%) │
├─────────┼─────────┼──────────────┼─────────────────┼───────────┼──────────┤
│ 0 │ '2.4.0' │ '2021-01-04' │ [] │ 723597 │ 16.4 │
│ 1 │ '2.5.0' │ '2022-06-26' │ [ 'v2-latest' ] │ 618374 │ 14 │
│ 2 │ '4.5.3' │ '2022-10-15' │ [ 'latest' ] │ 464627 │ 10.5 │
│ 3 │ '2.1.1' │ '2018-05-17' │ [] │ 401993 │ 9.1 │
│ 4 │ '2.3.0' │ '2019-09-20' │ [] │ 330729 │ 7.5 │
│ 5 │ '4.5.1' │ '2022-05-17' │ [] │ 286374 │ 6.5 │
│ 6 │ '3.1.3' │ '2021-03-12' │ [ 'v3-latest' ] │ 263550 │ 6 │
│ 7 │ '4.4.1' │ '2022-01-06' │ [] │ 174079 │ 3.9 │
│ 8 │ '4.5.2' │ '2022-09-02' │ [] │ 148607 │ 3.4 │
│ 9 │ '2.2.0' │ '2018-11-28' │ [] │ 143480 │ 3.2 │
└─────────┴─────────┴──────────────┴─────────────────┴───────────┴──────────┘
Ratio of downloads through versions shown in the table: 80.43%
Total weekly downloads: 4,420,400
Please leave the ranges so that any new versions would also be included in testing. See tedious for an example.
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream socket.io from ext-js repo to contrib.
The socket.io package has 5M weekly downloads on npm. The instrumentation has 4.6K weekly downloads on npm and it has been running in production environments for about 2 years with no issues.
I took the opportunity of changing the instrumentation package name and applied a few breaking changes which are documented in the README.md file.
The code itself is ported AS IS and can be improved in future PRs.