feat(lambda): add OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION environment variable #1227

dyladan · 2022-10-13T18:24:52Z

Adds an option to configure the disableAwsContextPropagation by environment variable

…ment option

codecov · 2022-10-13T19:04:55Z

Codecov Report

Merging #1227 (c05e3cf) into main (8499b16) will decrease coverage by 0.98%.
The diff coverage is 93.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
- Coverage   96.13%   95.15%   -0.98%     
==========================================
  Files          14       17       +3     
  Lines         906     1177     +271     
  Branches      197      249      +52     
==========================================
+ Hits          871     1120     +249     
- Misses         35       57      +22

Impacted Files	Coverage Δ
...strumentation-document-load/src/instrumentation.ts	`98.13% <88.88%> (-0.86%)`	⬇️
...-instrumentation-aws-lambda/src/instrumentation.ts	`94.18% <100.00%> (ø)`

... and 2 files with indirect coverage changes

plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts

blumamir · 2022-10-16T05:30:18Z

plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts

@@ -77,6 +78,18 @@ export class AwsLambdaInstrumentation extends InstrumentationBase {

  constructor(protected override _config: AwsLambdaInstrumentationConfig = {}) {
    super('@opentelemetry/instrumentation-aws-lambda', VERSION, _config);


WDYT about modifying the config object before using it as a paramater in the super call? might be a bit more robust IMO

e.g, apply the env variable logic first, construct an updated config object, and only then call super with this final config.

plugins/node/opentelemetry-instrumentation-aws-lambda/test/integrations/lambda-handler.test.ts

plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts

codeboten

@dyladan I was about to submit this same PR! It would be great to have this shipped

…ronment variable The variable `OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION` can be used to disable aws context propagation. This is similar to the proposed changes in the JS implementation: open-telemetry/opentelemetry-js-contrib#1227 Signed-off-by: Alex Boten <[email protected]>

…ronment variable (#1507) * Adds an option to configure `disable_aws_context_propagation` by environment variable The variable `OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION` can be used to disable aws context propagation. This is similar to the proposed changes in the JS implementation: open-telemetry/opentelemetry-js-contrib#1227 Signed-off-by: Alex Boten <[email protected]> * update changelog * Apply suggestions from code review Co-authored-by: Srikanth Chekuri <[email protected]> Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Srikanth Chekuri <[email protected]>

blumamir · 2023-01-02T03:01:51Z

There are still some open comments in this PR which I think are easy to address.
Can you please take a look and fix/resolve the comments, and then rebase so it can be merged?

…ation-env

blumamir · 2023-02-08T09:58:16Z

@dyladan - I cannot rebase this PR.
I think it is ready to be merged. Can you please rebase and merge?

blumamir · 2023-02-08T14:16:52Z

Needs to run lint:fix and check why tests are failing.

…ation-env

codeboten

There's been an update toe the spec to change the behaviour and add a span link for the trace available in the environment variable. See open-telemetry/opentelemetry-specification#3166 and here's an example implementation: open-telemetry/opentelemetry-specification#3166. This change can be addressed separately

github-actions · 2023-04-17T06:32:24Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions · 2023-05-08T06:31:38Z

This PR was closed because it has been stale for 14 days with no activity.

…ation-env

feat(lambda): add OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION environ…

2e0264d

…ment option

dyladan requested review from a team and Aneurysm9 October 13, 2022 18:24

github-actions bot assigned NathanielRN and willarmiros Oct 13, 2022

github-actions bot requested review from NathanielRN and willarmiros October 13, 2022 18:25

Aneurysm9 approved these changes Oct 13, 2022

View reviewed changes

Lint

bbbda56

blumamir reviewed Oct 16, 2022

View reviewed changes

codeboten approved these changes Dec 13, 2022

View reviewed changes

Merge branch 'main' into lambda-disable-propagation-env

392b5c5

JacksonWeber approved these changes Dec 15, 2022

View reviewed changes

mwear approved these changes Dec 16, 2022

View reviewed changes

codeboten mentioned this pull request Dec 19, 2022

Adds an option to configure disable_aws_context_propagation by environment variable open-telemetry/opentelemetry-python-contrib#1507

Merged

6 tasks

codeboten mentioned this pull request Jan 18, 2023

add feature matrix open-telemetry/opentelemetry-lambda#430

Merged

dyladan added 3 commits January 25, 2023 13:59

Merge remote-tracking branch 'origin/main' into lambda-disable-propag…

95abf9d

…ation-env

feat: copy object to prevent modification

7f40ea8

test: add coverage

e2da529

blumamir approved these changes Feb 8, 2023

View reviewed changes

Merge branch 'main' into lambda-disable-propagation-env

a36ba8e

dyladan added 2 commits February 10, 2023 12:41

Merge remote-tracking branch 'origin/main' into lambda-disable-propag…

414ea49

…ation-env

chore: lint

7df12bc

codeboten suggested changes Feb 10, 2023

View reviewed changes

codeboten approved these changes Feb 10, 2023

View reviewed changes

github-actions bot added the stale label Apr 17, 2023

github-actions bot closed this May 8, 2023

dyladan reopened this Jun 16, 2023

Merge remote-tracking branch 'origin/main' into lambda-disable-propag…

4227ac2

…ation-env

github-actions bot removed the stale label Jun 19, 2023

dyladan added 2 commits June 28, 2023 11:45

Fix build

aa78b93

Merge remote-tracking branch 'origin/main' into lambda-disable-propag…

c05e3cf

…ation-env

dyladan merged commit 8777cbd into open-telemetry:main Jun 28, 2023

dyladan mentioned this pull request Jun 28, 2023

chore: release main #1539

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lambda): add OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION environment variable #1227

feat(lambda): add OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION environment variable #1227

dyladan commented Oct 13, 2022

codecov bot commented Oct 13, 2022 •

edited

Loading

blumamir Oct 16, 2022 •

edited

Loading

dyladan Jan 25, 2023

codeboten left a comment

blumamir commented Jan 2, 2023

blumamir commented Feb 8, 2023

blumamir commented Feb 8, 2023

codeboten left a comment •

edited

Loading

github-actions bot commented Apr 17, 2023

github-actions bot commented May 8, 2023

		@@ -77,6 +78,18 @@ export class AwsLambdaInstrumentation extends InstrumentationBase {

		constructor(protected override _config: AwsLambdaInstrumentationConfig = {}) {
		super('@opentelemetry/instrumentation-aws-lambda', VERSION, _config);

feat(lambda): add OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION environment variable #1227

feat(lambda): add OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION environment variable #1227

Conversation

dyladan commented Oct 13, 2022

codecov bot commented Oct 13, 2022 • edited Loading

Codecov Report

blumamir Oct 16, 2022 • edited Loading

Choose a reason for hiding this comment

dyladan Jan 25, 2023

Choose a reason for hiding this comment

codeboten left a comment

Choose a reason for hiding this comment

blumamir commented Jan 2, 2023

blumamir commented Feb 8, 2023

blumamir commented Feb 8, 2023

codeboten left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Apr 17, 2023

github-actions bot commented May 8, 2023

codecov bot commented Oct 13, 2022 •

edited

Loading

blumamir Oct 16, 2022 •

edited

Loading

codeboten left a comment •

edited

Loading