Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dataloader to release-please manifest and fix mongoose #1202

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Sep 27, 2022

Which problem is this PR solving?

We forgot to add instrumentation-dataloader to the manifest and instrumentation-mongoose had a wrong path.

@rauno56 rauno56 requested a review from a team September 27, 2022 08:13
@rauno56 rauno56 enabled auto-merge (squash) September 27, 2022 08:15
@Flarna
Copy link
Member

Flarna commented Sep 27, 2022

I'm still confused about which files need to be touched to keep release please happy. I thought that .release-please-manifest.json is updated by release please and users have to add their module only in release-please-config.json?

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1202 (2af4c55) into main (3898b11) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1202   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          14       14           
  Lines         893      893           
  Branches      191      191           
=======================================
  Hits          858      858           
  Misses         35       35           

@rauno56
Copy link
Member Author

rauno56 commented Sep 27, 2022

I feel you. I'm constantly confused myself as well.

Adding packages to manifest is only important because we don't release 1.0.0 as the first version. In my mind:

  • manifest -> release please's state;
  • config -> our preferences for release please.

@rauno56 rauno56 merged commit b49aed7 into open-telemetry:main Sep 27, 2022
@rauno56 rauno56 deleted the chore/new-pkg-rp-manifest branch September 27, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants