feat(mongodb): support v5

[GuillaumeDeconinck]

Which problem is this PR solving?

• @opentelemetry/instrumentation-mongodb: Handle version 5 of MongoDB NodeJS Driver

Short description of the changes

• feat(mongodb): Extend range of versions allowed for v4 patches to include v5
• test(mongodb) Add test cases for v5
  • Duplicate of v4 with just callbacks removed (as it has been removed in v5)
• chore(mongodb): Add command and configuration for v5 tests (package.json and .tav.yml)
• chore(mongodb): Renamed package.json command test-new-versions to test-v4 (and adapted .tav.yml for it)

Notes

• Unit tests of v4 are apparently running fine on MongoDB v5 when callbacks are adapted to Promises
• Tested quickly on an app with jaeger, otel collector and signoz, it seems to work fine too
• I'm not sure if there's any breaking change impacting the tracing in the V5. From what I understand, it's not the case

Feel free to comment/adapt/suggest things. I'm still learning on this kind of stuff 😉

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: GuillaumeDeconinck / name: Guillaume (c4efc68, 914c399, cded0c1, 7d2eead, e9118d3, 35004dc, bae68b1, bf14bae, 582c6a4, 7a2cf4b, e95ddbf, 997c642, e91dfe0, 9eacbf0, eb63033, f123719, ea1e82f, f24648f, f23eeac)
• ✅ login: haddasbronfman / name: Haddas Bronfman (5e19d4f, 6f740e7)
• ✅ login: pichlermarc / name: Marc Pichler (a74f02d, ff4f310, 669c57d, 4afcd91, df6c722)

[GuillaumeDeconinck]

Actually we tested a bit more today and noticed that the details of the queries are not present (e.g. the find parameters). I'll try to look at it soon.

[Eji4h]

I'm waiting for it.

[codecov]

Codecov Report

Merging #1451 (df6c722) into main (8499b16) will decrease coverage by 0.82%.
The diff coverage is 88.88%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
- Coverage   96.13%   95.32%   -0.82%     
==========================================
  Files          14       16       +2     
  Lines         906     1005      +99     
  Branches      197      208      +11     
==========================================
+ Hits          871      958      +87     
- Misses         35       47      +12     

Impacted Files	Coverage Δ
...strumentation-document-load/src/instrumentation.ts	98.13% <88.88%> (-0.86%)	⬇️

... and 2 files with indirect coverage changes

[GuillaumeDeconinck]

For what I said before:

Actually we tested a bit more today and noticed that the details of the queries are not present (e.g. the find parameters). I'll try to look at it soon.

Nevermind, I thought it automatically included all the parameters of find(), but the enhancedDatabaseReporting option is actually used for that. By default, only the first level is included, like before.

I think the PR can be reviewed.

[karanssj4]

@osherv any update on this? v5 is working similar to v4 except for dropping callback support

[icco]

I'm not an approver, but this looks good to me (there are currently merge conflicts though). We'd love to see this merged.

[GuillaumeDeconinck]

I quickly checked but it seems there are some tests failing now after fixing the conflicts.
I'll likely be able to fix these in the coming days.
Once done, I'll ping another maintainer as the (randomly?) assigned one doesn't seem to be active for the moment.

[GuillaumeDeconinck]

I've adapted the code based on the changes on main. The unit tests are all passing locally (with tav).

I had to use the same database name for all the tests, as right now the instrumentation only allows one poolName (and not one per connection). That's likely something to fix in another issue/PR.

@haddasbronfman Hello, sorry to ping you like that. I see you checked/worked on another PR for MongoDB. Would it possible to review this one when you have some time ? Thanks !

[icco]

@legendecas or @dyladan could we get a review here?

[pichlermarc]

Just a few questions from my side. 🙂

@haddasbronfman I know you've been contributing to this instrumentation lately, would you mind taking a look? 🙂

[GuillaumeDeconinck]

@pichlermarc Thanks for the review and for maintaining the branch up-to-date with master 🙂
I've updated the PR based on your comments

[haddasbronfman]

LGTM. thank you very much for handling this !!
 only one comment from my side.

[icco]

Hi, any chance we could get this reviewed? My company's traces are broken until we get this released

[pichlermarc]

Looks great, thanks 🙂
Waiting for one more CI run before merging 🙂

[pichlermarc]

Looks like there's a problem with our workflows - we'll have to take care of #1541 first to make CI pass. Sorry for the delay. 😞