chore: fix code style

open-telemetry · Jul 17, 2020 · 67169cb · 67169cb
1 parent 4056324
commit 67169cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/plugins/node/opentelemetry-koa-instrumentation/src/koa.ts b/plugins/node/opentelemetry-koa-instrumentation/src/koa.ts
@@ -26,7 +26,6 @@ import {
 } from './types';
 import { VERSION } from './version';
 import { getMiddlewareMetadata } from './utils';
-import Router = require('@koa/router');
 
 /** Koa instrumentation for OpenTelemetry */
 export class KoaInstrumentation extends BasePlugin<typeof koa> {
@@ -101,8 +100,7 @@ export class KoaInstrumentation extends BasePlugin<typeof koa> {
     const router = dispatchLayer.router;
 
     const routesStack = router?.stack ?? [];
-    for (let i = 0; i < routesStack.length; i++) {
-      const pathLayer: Router.Layer = routesStack[i];
+    for (const pathLayer of routesStack) {
       const path = pathLayer.path;
       const pathStack = pathLayer.stack;
       for (let j = 0; j < pathStack.length; j++) {

diff --git a/plugins/node/opentelemetry-koa-instrumentation/test/koa-router.test.ts b/plugins/node/opentelemetry-koa-instrumentation/test/koa-router.test.ts
@@ -80,8 +80,7 @@ describe('Koa Instrumentation - Router Tests', () => {
 
       const router = new KoaRouter();
       router.get('/post/:id', ctx => {
-        const id = ctx.params.id;
-        ctx.body = 'Post id: ' + id;
+        ctx.body = `Post id: ${ctx.params.id}`;
       });
 
       app.use(router.routes());