Merge branch 'main' into setConfig-ioredis-instrumentation

open-telemetry · Oct 14, 2021 · 0ff652d · 0ff652d
2 parents 4aaed5c + fe85fca
commit 0ff652d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/examples/express/tracer.js b/examples/express/tracer.js
@@ -54,7 +54,7 @@ function filterSampler(filterFn, parent) {
       if (!filterFn(spanName, spanKind, attr)) {
         return { decision: opentelemetry.SamplingDecision.NOT_RECORD };
       }
-      return parent.shouldSample(ctx, tid, name, kind, attr, links);
+      return parent.shouldSample(ctx, tid, spanName, spanKind, attr, links);
     },
     toString() {
       return `FilterSampler(${parent.toString()})`;

diff --git a/examples/web/README.md b/examples/web/README.md
@@ -1,6 +1,6 @@
 # Overview
 
-This example shows how to use [@opentelemetry/sdk-trace-web](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-web) with different instrumentations from contrib repo in a browser.
+This example shows how to use [@opentelemetry/sdk-trace-web][] with different instrumentations from contrib repo in a browser.
 
 ## Installation
 
@@ -18,11 +18,14 @@ npm start
 
 By default, the application will run on port `8090`.
 
-## Useful links
+## More information
 
-- For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
-- For more information on web tracing, visit: <https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-web>
+- [OpenTelemetry](https://opentelemetry.io)
+- [Web tracing][opentelemetry-sdk-trace-web]
 
 ## LICENSE
 
 Apache License 2.0
+
+[@opentelemetry/sdk-trace-web]: https://www.npmjs.com/package/@opentelemetry/sdk-trace-web
+[opentelemetry-sdk-trace-web]: https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-web