fix: move semantic-conventions to regular dependencies

These dependencies are imported at runtime but were only declared as devDependencies. This causes problems for people using these packages with yarn pnp.
open-telemetry · Jan 20, 2021 · 0789ae9 · 0789ae9
1 parent f8d8686
commit 0789ae9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/plugins/node/opentelemetry-plugin-ioredis/package.json b/plugins/node/opentelemetry-plugin-ioredis/package.json
@@ -46,7 +46,6 @@
   "devDependencies": {
     "@opentelemetry/context-async-hooks": "^0.14.0",
     "@opentelemetry/node": "^0.14.0",
-    "@opentelemetry/semantic-conventions": "^0.14.0",
     "@opentelemetry/test-utils": "^0.12.1",
     "@opentelemetry/tracing": "^0.14.0",
     "@types/ioredis": "4.17.3",
@@ -69,6 +68,7 @@
   "dependencies": {
     "@opentelemetry/api": "^0.14.0",
     "@opentelemetry/core": "^0.14.0",
+    "@opentelemetry/semantic-conventions": "^0.14.0",
     "shimmer": "^1.2.1"
   }
 }
diff --git a/plugins/node/opentelemetry-plugin-mongodb/package.json b/plugins/node/opentelemetry-plugin-mongodb/package.json
@@ -43,7 +43,6 @@
   "devDependencies": {
     "@opentelemetry/context-async-hooks": "^0.14.0",
     "@opentelemetry/node": "^0.14.0",
-    "@opentelemetry/semantic-conventions": "^0.14.0",
     "@opentelemetry/tracing": "^0.14.0",
     "@types/mocha": "7.0.2",
     "@types/mongodb": "3.5.25",
@@ -64,6 +63,7 @@
   "dependencies": {
     "@opentelemetry/api": "^0.14.0",
     "@opentelemetry/core": "^0.14.0",
+    "@opentelemetry/semantic-conventions": "^0.14.0",
     "shimmer": "^1.2.1"
   }
 }