Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractBoundInstrument refcounts and keeps the state of mapped. #842

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 10, 2020

Split from #831

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #842 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #842      +/-   ##
============================================
+ Coverage     79.25%   79.51%   +0.26%     
- Complexity      792      798       +6     
============================================
  Files           105      105              
  Lines          2858     2861       +3     
  Branches        269      268       -1     
============================================
+ Hits           2265     2275      +10     
+ Misses          491      487       -4     
+ Partials        102       99       -3
Impacted Files Coverage Δ Complexity Δ
...telemetry/sdk/metrics/AbstractBoundInstrument.java 100% <100%> (+45.45%) 8 <8> (+5) ⬆️
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 67.56% <100%> (ø) 4 <1> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 67.56% <100%> (ø) 4 <1> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 67.56% <100%> (ø) 4 <1> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 67.56% <100%> (ø) 4 <1> (ø) ⬇️
...elemetry/opentracingshim/SpanContextShimTable.java 96.42% <0%> (+7.14%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cff8cc...219d1fe. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 11e0fb0 into open-telemetry:master Feb 12, 2020
@bogdandrutu bogdandrutu deleted the splitab branch February 12, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants