Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unbind to the Bound to simplify usage #834

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

bogdandrutu
Copy link
Member

I think this simplifies the usages of the bind/unbind pair.

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
Signed-off-by: Bogdan Cristian Drutu <[email protected]>
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bogdandrutu bogdandrutu merged commit e7be014 into open-telemetry:master Feb 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #834 into master will increase coverage by 0.15%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #834      +/-   ##
===========================================
+ Coverage     78.94%   79.1%   +0.15%     
+ Complexity      789     787       -2     
===========================================
  Files           105     105              
  Lines          2845    2838       -7     
  Branches        273     273              
===========================================
- Hits           2246    2245       -1     
+ Misses          494     489       -5     
+ Partials        105     104       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/io/opentelemetry/metrics/DefaultMeter.java 73.68% <0%> (+2.49%) 25 <0> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 64.7% <100%> (-1.01%) 4 <1> (-1)
...telemetry/sdk/metrics/AbstractBoundInstrument.java 54.54% <100%> (+4.54%) 3 <1> (+1) ⬆️
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 64.7% <100%> (-1.01%) 4 <1> (-1)
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 64.7% <100%> (-1.01%) 4 <1> (-1)
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 64.7% <100%> (-1.01%) 4 <1> (-1)
...elemetry/opentracingshim/SpanContextShimTable.java 96.42% <0%> (+7.14%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd7612...aea04c9. Read the comment docs.

@bogdandrutu bogdandrutu deleted the unbind branch February 7, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants