Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instrument's builder private class #819

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #819 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #819      +/-   ##
============================================
+ Coverage     79.04%   79.11%   +0.07%     
- Complexity      785      790       +5     
============================================
  Files           104      104              
  Lines          2811     2811              
  Branches        269      269              
============================================
+ Hits           2222     2224       +2     
+ Misses          484      483       -1     
+ Partials        105      104       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/io/opentelemetry/sdk/metrics/MeterSdk.java 64.7% <100%> (ø) 8 <4> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 58.62% <100%> (ø) 4 <1> (+1) ⬆️
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 58.62% <100%> (ø) 4 <1> (+1) ⬆️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 58.62% <100%> (ø) 4 <1> (+1) ⬆️
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 58.62% <100%> (ø) 4 <1> (+1) ⬆️
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 91.51% <0%> (+1.21%) 45% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2843a1...3e6e9fe. Read the comment docs.

@bogdandrutu
Copy link
Member Author

Trivial change, merging

@bogdandrutu bogdandrutu merged commit 65179f8 into open-telemetry:master Feb 5, 2020
@bogdandrutu bogdandrutu deleted the builderprivate branch March 10, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants