Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves #767 HttpTraceContext should not throw exceptions for non-fatal cases #782

Merged
merged 6 commits into from
Jan 29, 2020
Merged

Solves #767 HttpTraceContext should not throw exceptions for non-fatal cases #782

merged 6 commits into from
Jan 29, 2020

Conversation

DotSpy
Copy link
Member

@DotSpy DotSpy commented Jan 22, 2020

No description provided.

@jkwatson
Copy link
Contributor

looks like you have some failing tests.

@codecov-io
Copy link

codecov-io commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #782 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #782      +/-   ##
============================================
- Coverage     78.58%   78.47%   -0.12%     
  Complexity      778      778              
============================================
  Files           101      101              
  Lines          2779     2787       +8     
  Branches        268      269       +1     
============================================
+ Hits           2184     2187       +3     
- Misses          493      498       +5     
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...ntelemetry/trace/propagation/HttpTraceContext.java 94.93% <100%> (+0.41%) 16 <0> (ø) ⬇️
.../io/opentelemetry/opentracingshim/Propagation.java 75.75% <100%> (+1.56%) 5 <0> (+1) ⬆️
...a/io/opentelemetry/opentracingshim/TracerShim.java 54.83% <0%> (-12.91%) 11% <0%> (ø)
...elemetry/opentracingshim/SpanContextShimTable.java 89.28% <0%> (-7.15%) 7% <0%> (-1%)
...elemetry/sdk/trace/export/BatchSpansProcessor.java 89.65% <0%> (+0.86%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4f373...3ca82bc. Read the comment docs.

jkwatson
jkwatson approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@bogdandrutu bogdandrutu merged commit 8b4c148 into open-telemetry:master Jan 29, 2020
@DotSpy DotSpy deleted the context_return_invalid branch January 30, 2020 20:56
@jkwatson jkwatson mentioned this pull request Jan 30, 2020
Closed
@DotSpy DotSpy mentioned this pull request Feb 26, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jkwatson jkwatson jkwatson approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@arminru arminru Awaiting requested review from arminru

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@songy23 songy23 Awaiting requested review from songy23

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DotSpy @jkwatson @codecov-io @carlosalberto @bogdandrutu @vladislav-kiva