Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly allow null into CompletableResultCode.failExceptionally() #6963

Merged

Conversation

breedx-splk
Copy link
Contributor

Relates to this comment: open-telemetry/opentelemetry-android#709 (comment)

This is useful when chaining result codes and wanting to not lose an existing throwable. It was completely valid before, but it wasn't documented.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (1fcbed8) to head (8863f2a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6963   +/-   ##
=========================================
  Coverage     90.10%   90.10%           
  Complexity     6601     6601           
=========================================
  Files           730      730           
  Lines         19843    19843           
  Branches       1955     1955           
=========================================
  Hits          17879    17879           
- Misses         1369     1370    +1     
+ Partials        595      594    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit c1b9ec7 into open-telemetry:main Dec 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants