Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience method setAttribute(Attribute<Long>, int) to SpanBuilder (matching the existing convenience method in Span) #6884

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Add convenience method setAttribute(Attribute<Long>, int) to SpanBuilder (matching the existing convenience method in Span) #6884

merged 5 commits into from
Nov 18, 2024

Conversation

Stoyas
Copy link
Contributor

@Stoyas Stoyas commented Nov 15, 2024 •
edited by trask
Loading

Resolves #6870

@Stoyas Stoyas requested a review from a team as a code owner November 15, 2024 23:52
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 15, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Stoyas
Copy link
Contributor Author

Stoyas commented Nov 15, 2024

/easycla

1 similar comment
@trask
Copy link
Member

trask commented Nov 16, 2024

/easycla

@Stoyas Stoyas force-pushed the B2-6870-fixbuilder branch from 70de66c to 0deb45b Compare November 16, 2024 00:11
@breedx-splk
Copy link
Contributor

Resolves #6870

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.29%. Comparing base (ca98fc5) to head (b3519b8).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6884      +/-   ##
============================================
- Coverage     90.30%   90.29%   -0.02%     
  Complexity     6589     6589              
============================================
  Files           729      729              
  Lines         19767    19768       +1     
  Branches       1944     1944              
============================================
- Hits          17851    17849       -2     
- Misses         1325     1327       +2     
- Partials        591      592       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

breedx-splk
breedx-splk approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@trask trask changed the title fix spanbuilder Add convenience method setAttribute(Attribute<Long>, int) to SpanBuilder (matching the existing convenience method in Span) Nov 16, 2024
@jack-berg jack-berg merged commit 4c30ec4 into open-telemetry:main Nov 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk approved these changes

@jack-berg jack-berg jack-berg approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
contribfest
Projects
None yet
Milestone
No milestone
4 participants
@Stoyas @trask @breedx-splk @jack-berg