Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Baggage.getEntry(String key) #6765

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

breedx-splk
Copy link
Contributor

Resolves #6729.

This prevents users from having to go through asMap() in order to fetch the metadata for a given BaggageEntry.

@breedx-splk breedx-splk requested a review from a team as a code owner October 4, 2024 17:32
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (a6a9acb) to head (5d1fd65).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/io/opentelemetry/api/baggage/Baggage.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6765      +/-   ##
============================================
+ Coverage     90.02%   90.09%   +0.06%     
- Complexity     6488     6544      +56     
============================================
  Files           719      728       +9     
  Lines         19587    19702     +115     
  Branches       1931     1935       +4     
============================================
+ Hits          17634    17750     +116     
+ Misses         1354     1349       -5     
- Partials        599      603       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit b6badb2 into open-telemetry:main Oct 11, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better API for interacting with BaggageEntryMetadata
4 participants