-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file configuration ComponentProvider support for samplers #6494
Merged
jack-berg
merged 7 commits into
open-telemetry:main
from
jack-berg:sampler-component-provider
Aug 28, 2024
Merged
Add file configuration ComponentProvider support for samplers #6494
jack-berg
merged 7 commits into
open-telemetry:main
from
jack-berg:sampler-component-provider
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6494 +/- ##
============================================
- Coverage 90.06% 90.02% -0.04%
- Complexity 6294 6302 +8
============================================
Files 698 699 +1
Lines 19032 19063 +31
Branches 1867 1870 +3
============================================
+ Hits 17141 17162 +21
- Misses 1315 1324 +9
- Partials 576 577 +1 ☔ View full report in Codecov by Sentry. |
6 tasks
@open-telemetry/java-approvers could use a look when you have a chance. Thanks! |
trask
approved these changes
Aug 28, 2024
...emetry/sdk/extension/trace/jaeger/sampler/internal/JaegerRemoteSamplerComponentProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #6457, #6493 adding file configuration support for custom Samplers.
As a part of this, adds ComponentProvider implementations for all the samplers maintained in this module (just JaegerRemoteSampler).