Read normalized otel.config.file property #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6105 +/- ##
=========================================
Coverage 91.12% 91.12%
Complexity 5742 5742
=========================================
Files 630 630
Lines 16844 16845 +1
Branches 1664 1664
=========================================
+ Hits 15349 15350 +1
Misses 1029 1029
Partials 466 466 ☔ View full report in Codecov by Sentry. |
trask
approved these changes
Jan 2, 2024
.../src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java
Outdated
Show resolved
Hide resolved
| @@ -479,10 +479,11 @@ public AutoConfiguredOpenTelemetrySdk build() { | |||
|
|
|||
| @Nullable | |||
| private static AutoConfiguredOpenTelemetrySdk maybeConfigureFromFile(ConfigProperties config) { | |||
| String configurationFile = config.getString("OTEL_CONFIG_FILE"); | |||
| String configurationFile = config.getString("otel.config.file"); | |||
…k/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now its impossible to trigger file configuration in autoconfigure.
Whether you set an environment variable
OTEL_CONFIG_FILEor system propertyotel.config.file, we're reading theOTEL_CONFIG_FILE, which never matches the normalized environment variable or system property 🤦. This fixes the bug.