Remove semconv #5807
Merged
Remove semconv #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Sep 11, 2023
…y-java into remove-semconv
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
breedx-splk
approved these changes
Sep 12, 2023
Comment on lines
+20
to
+22
| If you are looking for generated classes for | ||
| the [OpenTelemetry semantic conventions][opentelemetry-semantic-conventions], | ||
| see [semantic-conventions-java][opentelemetry-semantic-conventions-java]. |
|
Should resolve #5849 before merging. |
|
Anyone following please see this comment. I think we should proceed merging this without doing the maven relocation strategy. |
makes sense to me, thanks for writing up your analysis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we should remove right away or give the deprecation notice a few releases to sink in. Opening the PR just to have it done and to prompt the discussion.