Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LongHistogramAdviceConfigurer to improve api surface types #5689

Conversation

breedx-splk
Copy link
Contributor

It struck me as a little bit of an ergonomics problem to have to pass a collection of doubles when setting explicit bucket boundaries for a LongHistogram builder/advice.

See how the AdviceTest changes in this PR for an example of how this should feel a slight bit better.

@breedx-splk breedx-splk requested a review from a team August 7, 2023 22:16
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (d4a3b3b) 91.34% compared to head (510d56c) 91.34%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5689      +/-   ##
============================================
- Coverage     91.34%   91.34%   -0.01%     
  Complexity     4997     4997              
============================================
  Files           554      554              
  Lines         14793    14795       +2     
  Branches       1379     1379              
============================================
+ Hits          13513    13514       +1     
  Misses          883      883              
- Partials        397      398       +1     
Files Changed Coverage Δ
...ubator/metrics/ExtendedDoubleHistogramBuilder.java 0.00% <ø> (ø)
...ncubator/metrics/ExtendedLongHistogramBuilder.java 0.00% <ø> (ø)
.../opentelemetry/sdk/metrics/SdkDoubleHistogram.java 100.00% <ø> (ø)
...io/opentelemetry/sdk/metrics/SdkLongHistogram.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 8770703 into open-telemetry:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants