Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OtelVersionClassPlugin instead of reading version from resource #5622

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

jack-berg
Copy link
Member

Resolves #5369.

Converts remaining code that reads version from version.properties to instead obtain it from a generated class.

@jack-berg jack-berg requested a review from a team July 11, 2023 17:52
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9ecc6f0) 91.31% compared to head (3cc5e17) 91.31%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5622   +/-   ##
=========================================
  Coverage     91.31%   91.31%           
+ Complexity     4982     4978    -4     
=========================================
  Files           554      554           
  Lines         14749    14731   -18     
  Branches       1376     1376           
=========================================
- Hits          13468    13452   -16     
+ Misses          887      884    -3     
- Partials        394      395    +1     
Impacted Files Coverage Δ
...y/opencensusshim/OpenTelemetrySpanBuilderImpl.java 87.17% <100.00%> (+0.97%) ⬆️
...a/io/opentelemetry/opentracingshim/TracerShim.java 69.23% <100.00%> (-1.27%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit b0c5c04 into open-telemetry:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking getResourceAsStream() performance
2 participants